Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: horrendous file bloating when using Flac 1.3.3 binaries from Rarewares (Read 15571 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: horrendous file bloating when using Flac 1.3.3 binaries from Rarewares

Reply #25
I'll incorporate this and upload revised test binaries later today.

Re: horrendous file bloating when using Flac 1.3.3 binaries from Rarewares

Reply #26
And, here they are:

www.rarewares.org/files/lossless/flac-v1.3.3-b358381-mod2-x64.zip

www.rarewares.org/files/lossless/flac-v1.3.3-b358381-mod2-x86.zip

Just to confirm that these are not yet official, see above.

Re: horrendous file bloating when using Flac 1.3.3 binaries from Rarewares

Reply #27
Hi all,

As said before, I've already sent a patch for this issue here: https://github.com/xiph/flac/pull/251

However, that fixes the overflow triggered. I've now sent in a patch to fix the root cause: https://github.com/xiph/flac/pull/252

In short: I explained in post #20 that sometimes FLAC chooses the wrong rice parameter, which causes enormous file bloat. Because of an overflow, the FLAC encoder actually thinks that the resulting very large frame is the smallest possible. This overflow should be fixed in PR 251, the first patch. This second patch, PR 252, makes FLAC not choose the wrong rice parameter anymore, fixing the root cause.

That's great news. :)

Hope both fixes gets added soon.


 


Re: horrendous file bloating when using Flac 1.3.3 binaries from Rarewares

Reply #31
Flac 1.3.4 compiles on rarewares have the same problem again, because the fix (https://github.com/xiph/flac/pull/252) did not made it into version 1.3.4.

Re: horrendous file bloating when using Flac 1.3.3 binaries from Rarewares

Reply #32
Flac 1.3.4 compiles on rarewares have the same problem again, because the fix (https://github.com/xiph/flac/pull/252) did not made it into version 1.3.4.


If u grab any of my FLAC-git releases (from May or later) so is the fix in those releases since it was pushed/merged into the flac master in April.

Re: horrendous file bloating when using Flac 1.3.3 binaries from Rarewares

Reply #33
FLAC 1.3.4 git-3528fa2, including dlls, now at Rarewares. :)