Skip to main content
Topic: External Tags (Read 7771 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: External Tags

Reply #150
Those streams were broken with the decoder handling change I made to fix Converter metadata issue Anakunda noticed. The decoder is now chosen purely on file path and mime-type is ignored. I added mime-type support but something is still wrong, opening the FLAC stream takes way too long. I don't want to release an update until I know how to fix that.

Re: External Tags

Reply #151
Hi! sveakul, thanks! :)
For all these 4 links, the "ExternalAPEv2" tag type is not saved after the start of playback. I think this behavior occurred earlier than version 1.0.12.
Does this link work fine for you? http://secure.live-streams.nl/flac.flac
For some reason my playback is interrupted for that link.

Damn, I updated to 1.0.12 and now I have the same issues as you do!  Has to be because of the change Case mentioned in External Tags not looking at mime data for streams anymore.  Well now he's aware of it (thanks to you!) and we can wait for hopefully a quick fix.  Can't play several of my tagged streams now.  From what Case said it seems 1.0.7 was the last "safe" version for this but I don't think there is an "older versions" area it could be downloaded from in the meantime.

Re: External Tags

Reply #152
I released an update that adds the mime-type based decoder selection. It worked fast when I tested it but now it again seems to suffer from slowdowns with the linked FLAC stream.

Re: External Tags

Reply #153
Case: never got around to trying v1.0.12 (I'm a bit late, sorry), but v1.0.13 crashes as soon as I load a GBS file, so I can't confirm if the subsong tagging issue has been resolved.

Re: External Tags

Reply #154
Fixed.

Re: External Tags

Reply #155
Hi Case:  I updated to 1.0.14, but some streams still remain stuck in "Starting playback...", for example the stream Sergey77 reported (http://secure.live-streams.nl/flac.flac) , and also this one: http://rondo.iradio.fi:8000/klasu.flac .

Others seem only to intermittently have the problem, like http://89.223.45.5:8000/space-160 .

I was able to find a backup copy of Foobar I had made when using External Tags 1.0.7, and all streams work perfectly there doing an A/B between the ones with problems on 1.0.14.  A backup made using 1.0.10 also has the problems.

Re: External Tags

Reply #156
I could no longer replicate the slow opening of the FLAC stream or the links you provided with v1.0.14.

Could you test if the attached version works correctly for you. I changed the decoder search to try all decoders based on mime-type first before letting anything see the path.

Edit: Attachment removed as obsolete.

Re: External Tags

Reply #157
Noticed for v1.0.14.1:
1. When the External Tags (reader) is enabled, the behavior for these different (vorbis, FLAC) links is following:
Spoiler (click to show/hide)2. With decoder (External Tags (reader)) is enable, clip search with internal function by foo_youtube "Search (Integrated)" -  is slow down.
3. It seems the component affects the operation of the foo_youtube. Symptoms are as follows: immediately after installing the External Tags - the foo_youtube component works well, but then the HLS video and YouTube clips stop working. I still do not understand what affects this behavior.

Re: External Tags

Reply #158
I updated the previous attachment. There should no longer be slowdowns for streams with no tags.

Re: External Tags

Reply #159
@Case, the component works perfectly for me now!
Thanks for the update!

Re: External Tags

Reply #160
Hopefully everything works well with Nisto's use case too. The test version from the attachment is now released properly.

Re: External Tags

Reply #161
Case:  just tried 1.0.15, all the streams I had a problem with now open normally, thanks a lot for the fix!

Re: External Tags

Reply #162
Case: Hey, sorry for the late feedback again. It works now.

EDIT: Sorry to be a PITA once again, but there is one more small problem I've noticed. When you go to the "Edit External Tags" context menu, it immediately creates external tags if they don't exist. But if you cancel out of the Properties window, the external tags remain. I think it would be better if the edit menu was disabled if there are no external tags, and have an explicit "create external tags" menu instead. And maybe in advanced settings, you could have an option for whether or not to copy tags from the source file when creating external tags.

Re: External Tags

Reply #163
Updated. Again, making the search
NOT %__tagtype% HAS xterna
makes a few lonely files (no more than one from each album) show up. But this time, all disappeared with "Reload info from file(s) if changed", no need for "Reload info from file(s)".
Memento: this is Hydrogenaudio. Do not assume good faith.

Re: External Tags

Reply #164
EDIT: Sorry to be a PITA once again, but there is one more small problem I've noticed. When you go to the "Edit External Tags" context menu, it immediately creates external tags if they don't exist. But if you cancel out of the Properties window, the external tags remain. I think it would be better if the edit menu was disabled if there are no external tags, and have an explicit "create external tags" menu instead

+1 for me on this also;  I mentioned the same in a previous post:  https://hydrogenaud.io/index.php/topic,116141.msg960392.html#msg960392

..and thanks for putting up with us PITA's!!


Re: External Tags

Reply #165
Hi!
Case: please, look the crash report in attachment. Thanks.

Re: External Tags

Reply #166
I think it would be better if the edit menu was disabled if there are no external tags, and have an explicit "create external tags" menu instead.
What benefit would the wording difference give? Or do you mean creation would not open properties so you'd have to open properties separately if you wanted to make changes?

Case: please, look the crash report in attachment. Thanks.
I can't do anything with this as it doesn't show any stack trace or call path where external tags is involved. But I saw some crashes in the crash logger for which I can download memory dumps.

Re: External Tags

Reply #167
But I saw some crashes in the crash logger for which I can download memory dumps.
Ok I can send that.

Re: External Tags

Reply #168
I think it would be better if the edit menu was disabled if there are no external tags, and have an explicit "create external tags" menu instead.
What benefit would the wording difference give? Or do you mean creation would not open properties so you'd have to open properties separately if you wanted to make changes?

The real issue here is that external tags aren't removed when you cancel out of the Properties window. If you unintentionally hit "create external tags" by accident, then you know you need to remove them first in order to get to the source tags, but currently, the behavior is kind of implicit, so you wouldn't know you were editing External Tags if you subsequently went into a regular Properties window. Sometimes you may actually want to modify the source tags even if External Tags exist, but there currently is no way to do so. As an alternative, maybe you could add an explicit "edit file tags" menu? That would be really sweet, actually. The idea is to primarily edit external tags if they exist, but the source tags should still be editable by some means.

Re: External Tags

Reply #169
I think it would be better if the edit menu was disabled if there are no external tags, and have an explicit "create external tags" menu instead.
What benefit would the wording difference give? Or do you mean creation would not open properties so you'd have to open properties separately if you wanted to make changes?

My take on this would be that if a file or stream currently has no external tag, the context menu should show "Create External Tag" as an option for those entries, and open the Properties window for editing the new external tag.  If an external tag does already exists, then the context menu choice for those files/streams would only show the "Edit External Tags" choice (and Remove of course) when changes need to be made, which would also open the Properties window.

Re: External Tags

Reply #170
People suffering from crashes with 1.0.15 should update to latest version. It will no longer attempt to access the decoder after it's gone. Curious that the crash logger only has entries for this issue with 1.0.15 even though the problem has always been there.

Here's a test version for Nisto that won't tag anything with Edit tags feature unless one edits tags. There is no automatic refresh for the changed info as foobar2000 doesn't see them automatically. Not sure it can be added.

And there's additional context menu command to force-bypass External Tags and edit file tags directly.

Edit: attachment removed.

Re: External Tags

Reply #171
@Case: Really unfortunate about the inability to automatically refresh the displayed tags. It worked in earlier versions - what has changed? Are you required to pre-create the external tags for it to work?

There seems to be some bugs. In my case, simply opening "edit file tags" and doing a "remove tags" on a FLAC file won't save the changes (I've looked at the actual file outside of foobar2000; it still has the same timestamp and binary data). Also, adding a new tag will remove all the tag data - yikes!

Re: External Tags

Reply #172
Second test version with above issues fixed and with automatic refresh after external tag edition.

Context menu was changed around a bit and now only "Edit External Tags" and "Edit file tags" are visible by default.

There's also explicit "Create External Tags" command that works like old edit command, but it's only available if selection has files that don't have external tags yet (or if over 100 tracks are selected in which case all context display rule checks are bypassed not to delay the menu opening).

Re: External Tags

Reply #173
I'm okay with the new behavior. Thanks for all the hard work, Case!

Just one small thing so far: the "remove external tags" menu is missing.

Also, being that the "old method" now doesn't actually create external tags immediately upon entering the Properties window (it does so when actually Apply'ing or OK'ing), AND it automatically refreshes tags, I would be okay with you using whatever that programmatic approach is in all cases. I was expecting that, if I wrote external tags to >100 files, it would not automatically refresh the tags, or that it would immediately create external tags when the Properties window appeared - but evidently that isn't the case, which is great. Really, I don't even see a difference between the two methods.
EDIT: Okay, so you mention a "create" menu, but.. that doesn't show for me when selecting >100 files. Not even >1000 files. There's still only an "edit" menu.
EDIT 2: Sorry! Found it in the shift-context-menu.

Re: External Tags

Reply #174
The remove command is there, hidden by default like before. If you had manually made it visible in Preferences it might have changed as its index is different now. All the commands are visible when opening the context menu while pressing Shift-key.

The Edit command in the test version is different from the Create command as Edit does nothing unless you actually change something. Properties dialog won't retag files if there's nothing to do.

 
SimplePortal 1.0.0 RC1 © 2008-2018