Skip to main content

Topic: Batch attach pictures greyed out (Read 2662 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.
  • SigHunter
  • [*][*]
Batch attach pictures greyed out
Hey there,

since some Foobar versions the "batch attach pictures" function only works for a limited count of files.

i used to be able to select all my files in playlist/library (~4k) and do the batch attach pictures thingy.

however now it is greyed out, for some reason. when i select fewer songs (like 500) its black and works as before.

why is that and why doesn't it work as it used to?

500 files:


4000 files:



edit:
tested it with a portable installation of 1.1.12, there it works, another portable (completely empty) install of 1.2.8, its grey as stated above
  • Last Edit: 16 June, 2013, 01:41:20 PM by SigHunter

  • dhromed
  • [*][*][*][*][*]
Batch attach pictures greyed out
Reply #1
Some of the files in the selection do not support attaching pictures?

  • SigHunter
  • [*][*]
Batch attach pictures greyed out
Reply #2
Some of the files in the selection do not support attaching pictures?

well, i only have flac + mp3s, and the same files work with foobar 1.2.0 and before.

is there some bugtracker or some way i can report this bug? (i think its a bug)

  • Peter
  • [*][*][*][*][*]
  • Administrator
Batch attach pictures greyed out
Reply #3
Rationale: when working on really large groups of files (100000 and more), certain seemingly harmless operations cause foobar2000 UI to lag.
In this case, checking if every file on the list supports album art operations caused UI lag before the context menu appeared. I added a workaround: the commands get grayed out if you select more than 1000 items as it seemed unlikely to me that anyone would want to batch attach pictures to so many files at once. I'll increase the limit for the next version so it hopefully does not bother you again.
If you wish to batch attach files to so many files in one pass, please tell me why exactly you want to do such thing and I'll take it into consideration.
  • Last Edit: 19 June, 2013, 05:17:58 AM by Peter

  • dhromed
  • [*][*][*][*][*]
Batch attach pictures greyed out
Reply #4
If you wish to batch attach files to so many files in one pass, please tell me why exactly you want to do such thing and I'll take it into consideration.


I can select any number of items, and do things to them. Foobar has a strong reputation for being super-fast and being able to handle very large amounts of items in a playlist, so it's not immediately obvious that adding images would cause problems. If it takes time-- that's okay. Converting 4000 items also takes time. RG-scanning 4000 items also takes time. Why block the user for this one action?

  • ruebe
  • [*][*][*]
Batch attach pictures greyed out
Reply #5
If it takes time-- that's okay.


i beg to differ. i did numerous things with foobar, that took quite a considerable amount of time, e.g. mass deleting of unused tags, mass verification of integrity, mass moving
every now and then i want to stop/pause/cancel such operation and run into severe downside
for example, if i'm running a mass moving operation and i have stop it for whatever reaseon, there is no chance i can find out, practically that is, which items have already been moved
OTOH, mass operations can be problematic per se, e.g. mass verifing of integrity is completely useless, because the output is neither search- nor sortable

now, on the topic at hand; if someone is mass batch attaching pictures and has to stop for whatever reason in the middle, there is no way to find out to which songs pictures have not been added yet
with this in mind, i'm inclinded to think that preventing (too) obsesive operations help users to keep their sanity

  • Rollin
  • [*][*][*][*]
Batch attach pictures greyed out
Reply #6
mass verifing of integrity is completely useless, because the output is neither search- nor sortable

You can export log of verification to simple txt file. All "bad" files will be listed in the end of log. It is very search- and sortable.

  • Silversight
  • [*][*][*][*]
Batch attach pictures greyed out
Reply #7
Since the cause for the UI lag is a mass feature check on the selected files, maybe foobar2000 could only check if a file supports album art during the process – immediately before it tries to write the album art to the file. This has multiple benefits:
  • Pictures could be attached to many files even when one of them doesn't support album art
  • No UI lag (of course)
  • Possible console output of non-working files (and reasons why)
  • More consistency across different features – after all, the Properties window doesn't deactivate the OK/Apply buttons when one or all of the files is/are read-only. Same with the RG scanner.
Nothing is impossible if you don't need to do it yourself.

  • lvqcl
  • [*][*][*][*][*]
  • Developer
Batch attach pictures greyed out
Reply #8
Why block the user for this one action?

To prevent a noticeable pause between right-click and context menu appearance.

  • ruebe
  • [*][*][*]
Batch attach pictures greyed out
Reply #9
mass verifing of integrity is completely useless, because the output is neither search- nor sortable

You can export log of verification to simple txt file. All "bad" files will be listed in the end of log. It is very search- and sortable.

to my defense, i was talking about the pop up window
beyond that: my bad, i apparently misread a few lines in the log file; however, i wouldn't call a log file an interactive enviroment, and thus think that the pop up window could be improved, but that's off topic

anyway, sorry for making false claims; i however hope that this does not invalidate my initial post as a whole

  • dhromed
  • [*][*][*][*][*]
Batch attach pictures greyed out
Reply #10
If it takes time-- that's okay.

now, on the topic at hand; if someone is mass batch attaching pictures and has to stop for whatever reason in the middle, there is no way to find out to which songs pictures have not been added yet
with this in mind, i'm inclinded to think that preventing (too) obsesive operations help users to keep their sanity


I see what you mean, but disabling a menu item at some random "reasonable" item count is definitely not the solution to that specific problem.

Why block the user for this one action?

To prevent a noticeable pause between right-click and context menu appearance.


That seems a very silly reason to me.

The crux of the problem is this:
Quote
In this case, checking if every file on the list supports album art operations caused UI lag before the context menu appeared


I don't think picking a number on a whim is a reasonable workaround to this problem. I understand the desire is to have a dynamic context menu that responds to the capabilities of the selected items, but why not give that up, display the option at all times, and let the output popup tell the user which items were processed and which were skipped?

I also think it's bad UX if there could be 1 unknown item in a large selection that spoils a user's ability to make some change.

  • Peter
  • [*][*][*][*][*]
  • Administrator
Batch attach pictures greyed out
Reply #11
I've changed the feature to give up checking whether files support album art operations or not after N items instead. The next update will have the fix. Thanks for bringing it up.

  • SigHunter
  • [*][*]
Batch attach pictures greyed out
Reply #12
I've changed the feature to give up checking whether files support album art operations or not after N items instead. The next update will have the fix. Thanks for bringing it up.

awesome, thank you!